styling with styler #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzwalthert
commented
Aug 8, 2017
| } | ||
| new_quosure(lazy, env) | ||
| }, | ||
| list = |
Author
There was a problem hiding this comment.
Not sure about how to continue after },. Do you think it's done right now?
Author
|
Reference (#93). |
lorenzwalthert
commented
Aug 8, 2017
|
|
||
| test_that("can use non-syntactic names", { | ||
| out <- tibble("foo bar" = list(1:2, 3)) %>% unnest() | ||
| out <- tibble("foo bar" = list(1:2, 3)) %>% |
Author
There was a problem hiding this comment.
single line pipes not yet supported but issue is open (#74)
lorenzwalthert
commented
Aug 8, 2017
| string = , | ||
| character = { | ||
| formula = as_quosure(lazy, env), | ||
| symbol =, |
Author
There was a problem hiding this comment.
should we add this rlang styling rule that puts a space between = and ,?
lorenzwalthert
force-pushed
the
f-styler
branch
from
f7e4e52 to
bd87931
Compare
Owner
|
I missed your comments, but we seem to have covered most by now? |
Author
|
This PR was for testing purposes of styler only and I think we can close it. |
Author
|
Maybe filing a PR to the upstream repo later (with an updated version of styler). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing styler.
Reference: r-lib/styler#93.